[
https://issues.apache.org/jira/browse/FLINK-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316656#comment-16316656
]
ASF GitHub Bot commented on FLINK-8347:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160208748
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -367,40 +366,31 @@ public ClusterClient retrieve(String applicationID) {
flinkConfiguration,
false);
} catch (Exception e) {
- throw new RuntimeException("Couldn't retrieve Yarn
cluster", e);
+ throw new ClusterRetrieveException("Couldn't retrieve
Yarn cluster", e);
}
}
@Override
- public YarnClusterClient deploySessionCluster(ClusterSpecification
clusterSpecification) {
+ public YarnClusterClient deploySessionCluster(ClusterSpecification
clusterSpecification) throws ClusterDeploymentException {
try {
return deployInternal(
clusterSpecification,
getYarnSessionClusterEntrypoint(),
null);
} catch (Exception e) {
- throw new RuntimeException("Couldn't deploy Yarn
session cluster", e);
+ throw new ClusterDeploymentException("Couldn't deploy
Yarn session cluster", e);
}
}
@Override
- public YarnClusterClient deployJobCluster(ClusterSpecification
clusterSpecification, JobGraph jobGraph) {
+ public YarnClusterClient deployJobCluster(ClusterSpecification
clusterSpecification, JobGraph jobGraph) throws ClusterDeploymentException {
try {
return deployInternal(
clusterSpecification,
getYarnJobClusterEntrypoint(),
jobGraph);
} catch (Exception e) {
- throw new RuntimeException("Could not deploy Yarn job
cluster.", e);
- }
- }
-
- @Override
--- End diff --
You should add `@Override` to the other overload of `terminateCluster` now.
> Make Cluster id typesafe
> ------------------------
>
> Key: FLINK-8347
> URL: https://issues.apache.org/jira/browse/FLINK-8347
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Currently, the cluster id is of type {{String}}. We should make the id
> typesafe to avoid mixups between different {{CustomCommandLines}} and
> {{ClusterDescriptors}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
