[
https://issues.apache.org/jira/browse/FLINK-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316730#comment-16316730
]
ASF GitHub Bot commented on FLINK-8347:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160209875
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -83,7 +83,7 @@ public void
testClusterClientRetrievalOfFinishedYarnApplication() throws IOExcep
temporaryFolder.newFolder().getAbsolutePath(),
yarnClient);
- clusterDescriptor.retrieve(clusterId);
+ clusterDescriptor.retrieve(applicationId);
fail("We should not be able to retrieve ClusterClient for a
finished Yarn application.");
--- End diff --
As written on a previous PR, `fail` should not be used in this case.
> Make Cluster id typesafe
> ------------------------
>
> Key: FLINK-8347
> URL: https://issues.apache.org/jira/browse/FLINK-8347
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Currently, the cluster id is of type {{String}}. We should make the id
> typesafe to avoid mixups between different {{CustomCommandLines}} and
> {{ClusterDescriptors}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
