Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4587#discussion_r160372500
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -150,16 +126,13 @@
         */
        private boolean nfaChanged;
     
    -   public NFA(
    -                   final TypeSerializer<T> eventSerializer,
    +   public NFA(final TypeSerializer<T> eventSerializer,
                        final long windowTime,
                        final boolean handleTimeout) {
    -
                this.eventSerializer = eventSerializer;
    --- End diff --
    
    this PR does not change anything in this manner (previously it also should 
not be null), but I agree we can add this check


---

Reply via email to