Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4587#discussion_r160895447
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java
---
@@ -1,55 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.cep.pattern;
-
-import org.apache.flink.api.common.functions.FilterFunction;
-
-/**
- * A filter function which combines two filter functions with a logical
and. Thus, the filter
- * function only returns true, iff both filters return true.
- *
- * @param <T> Type of the element to filter
- * @deprecated This is only used when migrating from an older Flink
version.
- * Use the {@link org.apache.flink.cep.pattern.conditions.AndCondition}
instead.
- */
-@Deprecated
-public class AndFilterFunction<T> implements FilterFunction<T> {
--- End diff --
I am not sure if we should bring back these classes.
I would recommend to simply throw an exception saying that 1.2 version is
no longer supported. The reason for this is:
1) not many people seem to be using CEP in 1.2
2) the code is already a bit complicated with all the migration magic.
What do you think about that as a solution @dawidwys and @pnowojski ?
---
