[GitHub] flink pull request #4587: [FLINK-7511] [cep] Remove dead code after dropping...

[dawidwys]

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4587#discussion_r160524740
  
    --- Diff: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -150,16 +126,13 @@
         */
        private boolean nfaChanged;
     
    -   public NFA(
    -                   final TypeSerializer<T> eventSerializer,
    +   public NFA(final TypeSerializer<T> eventSerializer,
                        final long windowTime,
                        final boolean handleTimeout) {
    -
                this.eventSerializer = eventSerializer;
    --- End diff --
    
    The difference in handling `null` seems strange to me. Could you tell me 
how did you check it?
    
    Anyway as I already said will add the check.


---