Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5219#discussion_r160699257
  
    --- Diff: 
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
 ---
    @@ -149,23 +153,26 @@ public void testTriggerSavepointFailureIllegalJobID() 
throws Exception {
        public void testTriggerSavepointCustomTarget() throws Exception {
                replaceStdOutAndStdErr();
     
    -           try {
    -                   JobID jobId = new JobID();
    +           JobID jobId = new JobID();
     
    -                   String savepointDirectory = "customTargetDirectory";
    +           String savepointDirectory = "customTargetDirectory";
     
    -                   MockedCliFrontend frontend = new 
SavepointTestCliFrontend(savepointDirectory);
    +           final ClusterClient clusterClient = 
createClusterClient(savepointDirectory);
    +
    +           try {
    +                   MockedCliFrontend frontend = new 
MockedCliFrontend(clusterClient);
     
                        String[] parameters = { jobId.toString(), 
savepointDirectory };
    -                   int returnCode = frontend.savepoint(parameters);
    +                   frontend.savepoint(parameters);
     
    -                   assertEquals(0, returnCode);
    --- End diff --
    
    Backport of tests.


---

Reply via email to