[GitHub] flink pull request #5219: [FLINK-8332] [flip6] Move savepoint dispose into C...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5219#discussion_r160699710
  
    --- Diff: 
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
 ---
    @@ -128,13 +131,14 @@ public void testTriggerSavepointFailureIllegalJobID() 
throws Exception {
                replaceStdOutAndStdErr();
     
                try {
    -                   CliFrontend frontend = new 
CliFrontend(CliFrontendTestUtils.getConfigDir());
    +                   CliFrontend frontend = new MockedCliFrontend(new 
StandaloneClusterClient(
    +                           new Configuration(),
    +                           new TestingHighAvailabilityServices()));
     
                        String[] parameters = { "invalid job id" };
                        int returnCode = frontend.savepoint(parameters);
     
    -                   assertTrue(returnCode != 0);
    -                   assertTrue(buffer.toString().contains("not a valid 
ID"));
    --- End diff --
    
    I think it's not important. We all know it will get removed anyways.


---