Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/5239#discussion_r160941763
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -210,10 +211,11 @@ public void testHeartbeatTimeoutWithJobManager()
throws Exception {
tmConfig,
taskManagerLocation,
mock(MemoryManager.class),
- mock(IOManager.class),
+
mock(IOManager.class),mock(TaskExecutorLocalStateStoresManager.class),
--- End diff --
Can all of the `mock(TaskExecutorLocalStateStoresManager.class)` be
replaced with: `new TaskExecutorLocalStateStoresManager();` (with an empty
array of for `localStateRootDirectories`) or maybe `new
TaskExecutorLocalStateStoresManager(sameThreadExecutor());`?
---
