Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r160912998
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ---
    @@ -380,6 +390,20 @@ public void postStop() throws Exception {
                        ResultPartitionConsumableNotifier 
resultPartitionConsumableNotifier = 
jobManagerConnection.getResultPartitionConsumableNotifier();
                        PartitionProducerStateChecker partitionStateChecker = 
jobManagerConnection.getPartitionStateChecker();
     
    +                   final TaskLocalStateStore localStateStore = 
localStateStoresManager.localStateStoreForTask(
    +                           jobId,
    +                           taskInformation.getJobVertexId(),
    +                           tdd.getSubtaskIndex());
    +
    +                   final JobManagerTaskRestore taskRestore = 
tdd.getTaskRestore();
    --- End diff --
    
    nit: could you while you are at it and expand this abbreviated `tdd` name? 
I am not sure how _test driven development_ could give me a `TaskRestore` :( 
    
    This can be done on top if you do not want to bother with pushing rename to 
the bottom.


---

Reply via email to