Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r160909861
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/StateUtil.java ---
    @@ -71,4 +72,22 @@ public static void discardStateFuture(RunnableFuture<? 
extends StateObject> stat
                        }
                }
        }
    +
    +   /**
    +    * Discards the given state collection future by first trying to cancel 
it. If this is not possible, then
    +    * the state object contained in the future is calculated and 
afterwards discarded.
    +    *
    +    * @param stateCollectionFuture to be discarded
    +    * @throws Exception if the discard operation failed
    +    */
    +   public static void discardStateCollectionFuture(
    --- End diff --
    
    It seems like a dead code both in this commit and it the whole PR. Isn't it?


---

Reply via email to