Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r160959867
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/StreamOperatorSnapshotRestoreTest.java
 ---
    @@ -98,7 +101,26 @@ public Integer getKey(Integer value) throws Exception {
                                TypeInformation.of(Integer.class),
                                MAX_PARALLELISM,
                                1 /* num subtasks */,
    -                           0 /* subtask index */);
    +                           0 /* subtask index */) {
    +
    +                   @Override
    +                   protected StreamTaskStateManager 
createStreamTaskStateManager(
    +                           Environment env,
    +                           StateBackend stateBackend,
    +                           ProcessingTimeService processingTimeService) {
    +
    +                           return new StreamTaskStateManagerImpl(env, 
stateBackend, processingTimeService) {
    +                                   @Override
    +                                   protected <K> 
InternalTimeServiceManager<?, K> internalTimeServiceManager(
    +                                           AbstractKeyedStateBackend<K> 
keyedStatedBackend,
    +                                           KeyContext keyContext,
    +                                           
Iterable<KeyGroupStatePartitionStreamProvider> rawKeyedStates) throws Exception 
{
    +
    +                                           return null;
    --- End diff --
    
    Does it make sense to return null in this method? Isn't this some kind of 
hack or a walkaround some underlying issue?


---

Reply via email to