Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/5307#discussion_r162468156
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/Offer.java ---
@@ -156,6 +164,16 @@ public long getOfferedTime() {
return attributeMap;
}
+ @Override
+ public Double getScalarValue(String name) {
+ return aggregatedScalarResourceMap.getOrDefault(name, 0.0);
+ }
+
+ @Override
+ public Map<String, Double> getScalarValues() {
+ return aggregatedScalarResourceMap;
--- End diff --
I notice that we return all scalar resource types (`cpus`, `gpus`, ...)
here, but in `LaunchableMesosWorker::getScalarRequests` we return only the
generic resource types (`gpus`). Would you please double-check that this is
expected by Fenzo? I wouldn't want Fenzo to double-count the `cpus` or
something.
---
