Github user eastcirclek commented on a diff in the pull request:
https://github.com/apache/flink/pull/5307#discussion_r162524332
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
@@ -238,6 +254,16 @@ public static MesosTaskManagerParameters
create(Configuration flinkConfig) {
cpus = Math.max(containeredParameters.numSlots(), 1.0);
}
+ double gpus = flinkConfig.getDouble(MESOS_RM_TASKS_GPUS, 0.0);
+ if (gpus < 0) {
+ throw new
IllegalConfigurationException(MESOS_RM_TASKS_GPUS.key() +
+ " cannot be negative");
+ }
+ if (gpus % 1 != 0) {
--- End diff --
I tested that `(1.000000000000001 % 1) != 0` is true while
`(1.0000000000000001 % 1) != 0` is false.
---
