Github user eastcirclek commented on a diff in the pull request:
https://github.com/apache/flink/pull/5307#discussion_r162809581
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/Offer.java ---
@@ -156,6 +164,16 @@ public long getOfferedTime() {
return attributeMap;
}
+ @Override
+ public Double getScalarValue(String name) {
+ return aggregatedScalarResourceMap.getOrDefault(name, 0.0);
+ }
+
+ @Override
+ public Map<String, Double> getScalarValues() {
+ return aggregatedScalarResourceMap;
--- End diff --
You are correct. It can cause confusion to contain an entry for `cpus` in
`Offer::aggregatedScalarResourceMap`. We need to return only generic resource
types (other than `cpus`, `mem`, `network`, and `disk`) as we do in
`LaunchableMesosWorker::getScalarRequests`.
---
