[GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5307#discussion_r164469976
  
    --- Diff: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
 ---
    @@ -238,6 +254,12 @@ public static MesosTaskManagerParameters 
create(Configuration flinkConfig) {
                        cpus = Math.max(containeredParameters.numSlots(), 1.0);
                }
     
    +           double gpus = 
Math.floor(flinkConfig.getDouble(MESOS_RM_TASKS_GPUS, 0.0));
    --- End diff --
    
    Are we rounding down because GPUs, cannot be shared? If this is the case, 
why don't we restrict the Flink configuration value to be an integer?


---