Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5441#discussion_r167882975
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/SqlClient.java
 ---
    @@ -0,0 +1,181 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.client;
    +
    +import org.apache.flink.table.client.cli.CliClient;
    +import org.apache.flink.table.client.cli.CliOptions;
    +import org.apache.flink.table.client.cli.CliOptionsParser;
    +import org.apache.flink.table.client.config.Environment;
    +import org.apache.flink.table.client.gateway.Executor;
    +import org.apache.flink.table.client.gateway.LocalExecutor;
    +import org.apache.flink.table.client.gateway.SessionContext;
    +
    +import java.io.IOException;
    +import java.net.URL;
    +import java.util.Arrays;
    +import java.util.Collections;
    +import java.util.List;
    +
    +/**
    + * SQL Client for submitting SQL statements. The client can be executed in 
two
    + * modes: a gateway and embedded mode.
    + *
    + * <p>- In gateway mode, the SQL CLI client connects to the REST API of 
the gateway and allows for
    --- End diff --
    
    I don't think we should document features that are not there yet (or at 
least mark them as future features).


---

Reply via email to