Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5441#discussion_r167944240
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ResultStore.java
 ---
    @@ -0,0 +1,124 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.client.gateway;
    +
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.JobManagerOptions;
    +import org.apache.flink.runtime.net.ConnectionUtils;
    +import org.apache.flink.table.client.SqlClientException;
    +import org.apache.flink.table.client.config.Deployment;
    +import org.apache.flink.table.client.config.Environment;
    +
    +import java.net.InetAddress;
    +import java.net.InetSocketAddress;
    +import java.net.UnknownHostException;
    +import java.util.ArrayList;
    +import java.util.HashMap;
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * Maintains dynamic results.
    + */
    +public class ResultStore {
    +
    +   private Configuration flinkConfig;
    +
    +   private Map<String, DynamicResult> results;
    +
    +   public ResultStore(Configuration flinkConfig) {
    +           this.flinkConfig = flinkConfig;
    +
    +           results = new HashMap<>();
    +   }
    +
    +   public DynamicResult createResult(Environment env) {
    +           if (!env.getExecution().isStreamingExecution()) {
    +                   throw new SqlExecutionException("Emission is only 
supported in streaming environments yet.");
    +           }
    +
    +           return new DynamicResult(
    +                   // determine gateway address (and port if possible)
    +                   getGatewayAddress(env.getDeployment()),
    +                   getGatewayPort(env.getDeployment()),
    +                   env.getExecution().isChangelogMode());
    +   }
    +
    +   public void storeResult(String resultId, DynamicResult result) {
    +           results.put(resultId, result);
    +   }
    +
    +   public DynamicResult getResult(String resultId) {
    +           return results.get(resultId);
    +   }
    +
    +   public void removeResult(String resultId) {
    +           final DynamicResult result = results.get(resultId);
    +           result.close();
    +           results.remove(resultId);
    +   }
    +
    +   public List<String> getResults() {
    +           return new ArrayList<>(results.keySet());
    +   }
    +
    +   // 
--------------------------------------------------------------------------------------------
    +
    +   private int getGatewayPort(Deployment deploy) {
    +           // try to get address from deployment configuration
    +           return deploy.getGatewayPort();
    +   }
    +
    +   private InetAddress getGatewayAddress(Deployment deploy) {
    +           // try to get address from deployment configuration
    +           final String address = deploy.getGatewayAddress();
    +
    +           // use manually defined address
    +           if (!address.isEmpty()) {
    +                   try {
    +                           return InetAddress.getByName(address);
    +                   } catch (UnknownHostException e) {
    +                           throw new SqlClientException("Invalid gateway 
address '" + address + "' for result retrieval.", e);
    +                   }
    +           } else {
    +                   // TODO cache this
    +                   // try to get the address by communicating to JobManager
    +                   final String jobManagerAddress = 
flinkConfig.getString(JobManagerOptions.ADDRESS);
    +                   final int jobManagerPort = 
flinkConfig.getInteger(JobManagerOptions.PORT);
    +                   if (jobManagerAddress != null && 
!jobManagerAddress.isEmpty()) {
    --- End diff --
    
    Will this work in a "real" cluster setup with SqlClient, JM, and TMs 
running on different machines?
    If I get the logic right, we need the host name of the client where the 
socket server is started, because the sink function will connect to that. If 
that is correct, this logic will only work if the JM runs on the same machine 
as the client.


---

Reply via email to