Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5441#discussion_r167881723
  
    --- Diff: flink-libraries/flink-sql-client/pom.xml ---
    @@ -0,0 +1,149 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +  http://www.apache.org/licenses/LICENSE-2.0
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0"; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd";>
    +
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <parent>
    +           <groupId>org.apache.flink</groupId>
    +           <artifactId>flink-libraries</artifactId>
    +           <version>1.5-SNAPSHOT</version>
    +           <relativePath>..</relativePath>
    +   </parent>
    +
    +   <artifactId>flink-sql-client</artifactId>
    +   <name>flink-sql-client</name>
    --- End diff --
    
    should we call the module `flink-sql-server`? In the future, the 
functionality will be split into server and client, and I assume most of the 
functionality will reside in the server.


---

Reply via email to