Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5458#discussion_r168171985
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ---
    @@ -270,10 +273,14 @@ public static TaskManagerServices fromConfiguration(
         * Creates a {@link MemoryManager} from the given {@link 
TaskManagerServicesConfiguration}.
         *
         * @param taskManagerServicesConfiguration to create the memory manager 
from
    +    * @param freeHeapMemoryWithDefrag an estimate of the size of the free 
heap memory
    +    * @param maxJvmHeapMemory the maximum JVM heap size
         * @return Memory manager
         * @throws Exception
         */
    -   private static MemoryManager 
createMemoryManager(TaskManagerServicesConfiguration 
taskManagerServicesConfiguration) throws Exception {
    +   private static MemoryManager 
createMemoryManager(TaskManagerServicesConfiguration 
taskManagerServicesConfiguration,
    +                                                                           
                         long freeHeapMemoryWithDefrag,
    +                                                                           
                         long maxJvmHeapMemory) throws Exception {
    --- End diff --
    
    The convention is to break parameter lists like
    ```
    public void a(
            A a,
            B b) {
        // foobar
    }
    ```


---

Reply via email to