Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5458#discussion_r168180788
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -530,10 +538,12 @@ public static long calculateNetworkBufferMemory(long
totalJavaMemorySize, Config
* </ul>.
*
* @param tmConfig task manager services configuration object
+ * @param maxJvmHeapMemory the maximum JVM heap size
*
* @return memory to use for network buffers (in bytes)
*/
- public static long
calculateNetworkBufferMemory(TaskManagerServicesConfiguration tmConfig) {
+ public static long
calculateNetworkBufferMemory(TaskManagerServicesConfiguration tmConfig,
+
long maxJvmHeapMemory) {
--- End diff --
Will fix ~
---
