[ https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366231#comment-16366231 ]
ASF GitHub Bot commented on FLINK-8667: --------------------------------------- GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5500 [FLINK-8667] expose key in KeyedBroadcastProcessFunction#onTimer() ## What is the purpose of the change Expose key in `KeyedBroadcastProcessFunction#onTimer(OnTimerContext<Key>)`. Hopefully this PR can make it into 1.5.0, in which release`KeyedBroadcastProcessFunction` will be out. Otherwise, we need to think about compatibility and it will be much harder to expose key in `KeyedBroadcastProcessFunction#onTimer()`. ## Brief change log Expose key in `KeyedBroadcastProcessFunction#onTimer(OnTimerContext<Key>)` ## Verifying this change This change is already covered by existing tests, such as *BroadcastStateITCase*. ## Does this pull request potentially affect one of the following parts: - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes) ## Documentation - Does this pull request introduce a new feature? (yes) - If yes, how is the feature documented? (JavaDocs) You can merge this pull request into a Git repository by running: $ git pull https://github.com/bowenli86/flink FLINK-8667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5500.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5500 ---- commit 2dcdedf072576e7e23fd220abf48c32c8355e5cc Author: Bowen Li <bowenli86@...> Date: 2018-02-15T20:37:44Z [FLINK-8667] expose key in KeyedBroadcastProcessFunction#onTimer() ---- > expose key in KeyedBroadcastProcessFunction#onTimer() > ----------------------------------------------------- > > Key: FLINK-8667 > URL: https://issues.apache.org/jira/browse/FLINK-8667 > Project: Flink > Issue Type: Improvement > Affects Versions: 1.5.0 > Reporter: Bowen Li > Assignee: Bowen Li > Priority: Major > Fix For: 1.5.0 > > > [~aljoscha] [~pnowojski] Since KeyedBroadcastProcessFunction is about to get > out of the door, I think it will be great to expose the timer's key in > KeyedBroadcastProcessFunction too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)