[ 
https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369055#comment-16369055
 ] 

ASF GitHub Bot commented on FLINK-8667:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5500#discussion_r169051920
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperatorTest.java
 ---
    @@ -204,6 +208,8 @@ public void testFunctionWithTimer() throws Exception {
     
                private final long timerTS;
     
    +           static final String EXPECTED_KEY = "6";
    --- End diff --
    
    Can not this be a non static field initialised in the constructor just as 
`timerTS` is? 


> expose key in KeyedBroadcastProcessFunction#onTimer()
> -----------------------------------------------------
>
>                 Key: FLINK-8667
>                 URL: https://issues.apache.org/jira/browse/FLINK-8667
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>
> [~aljoscha] [~pnowojski]  
> Since KeyedBroadcastProcessFunction is about to get out of the door, I think 
> it will be great to expose the timer's key in KeyedBroadcastProcessFunction 
> too. If we don't do it now, it will be much more difficult to add the feature 
> on later because of user app compatibility issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to