ASF GitHub Bot commented on FLINK-8667:

Github user pnowojski commented on a diff in the pull request:

    --- Diff: 
    @@ -169,7 +170,10 @@ public void open(Configuration parameters) throws 
Exception {
                public void processElement(Long value, KeyedReadOnlyContext 
ctx, Collector<String> out) throws Exception {
    +                   long currentTime = al.getAndIncrement();
    +                   ctx.timerService().registerEventTimeTimer(currentTime);
    +                   expectedTimeAndKey.put(currentTime, value);
    +                   expectedKeyAndTime.put(value, currentTime);
    --- End diff --
    What's the value of this `expectedKeyAndTime` mapping? because incrementing 
of the `al` counter, keys in the first map (`expectedTimeAndKey`) will always 
be unique and I think we can safely remove this second map.

> expose key in KeyedBroadcastProcessFunction#onTimer()
> -----------------------------------------------------
>                 Key: FLINK-8667
>                 URL: https://issues.apache.org/jira/browse/FLINK-8667
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
> [~aljoscha] [~pnowojski]  
> Since KeyedBroadcastProcessFunction is about to get out of the door, I think 
> it will be great to expose the timer's key in KeyedBroadcastProcessFunction 
> too. If we don't do it now, it will be much more difficult to add the feature 
> on later because of user app compatibility issue.

This message was sent by Atlassian JIRA

Reply via email to