[
https://issues.apache.org/jira/browse/FLINK-8459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374012#comment-16374012
]
ASF GitHub Bot commented on FLINK-8459:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5565
[FLINK-8459][flip6] Implement cancelWithSavepoint in RestClusterClient
## What is the purpose of the change
This pull request implements cancelWithSavepoint in RestClusterClient for
flip6.
## Brief change log
- split the function into two steps: send REST call `triggerSavepoint`
and send REST call `cancel`
## Verifying this change
This change added tests and can be verified as follows:
- Added a test to check savepoint path and job's termination state is
canceled.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8459
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5565
----
commit a4b97d8f305bed09c154fb88ba8e06879532e1ed
Author: vinoyang <vinoyang@...>
Date: 2018-02-23T06:52:11Z
[FLINK-8459][flip6] Implement cancelWithSavepoint in RestClusterClient
----
> Implement cancelWithSavepoint in RestClusterClient
> --------------------------------------------------
>
> Key: FLINK-8459
> URL: https://issues.apache.org/jira/browse/FLINK-8459
> Project: Flink
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 1.5.0
> Reporter: Gary Yao
> Assignee: vinoyang
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> Implement the method
> {{RestClusterClient#cancelWithSavepoint(JobID jobId, @Nullable String
> savepointDirectory)}}.
> by either taking a savepoint and cancel the job separately, or by migrating
> the logic in {{JobCancellationWithSavepointHandlers}}. The former will have
> different semantics because the checkpoint scheduler is not stopped. Thus it
> is not guaranteed that there won't be additional checkpoints between the
> savepoint and the job cancelation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
