ASF GitHub Bot commented on FLINK-8459:

Github user GJL commented on the issue:

    @yanghua Thanks for your contribution but I am afraid to tell you that we 
have changed our mind and decided that it is better not to allow checkpoints 
between the savepoint and job cancelation.
    #5622 already implements this.
    cc: @tillrohrmann 

> Implement cancelWithSavepoint in RestClusterClient
> --------------------------------------------------
>                 Key: FLINK-8459
>                 URL: https://issues.apache.org/jira/browse/FLINK-8459
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Assignee: Gary Yao
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
> Implement the method
>         {{RestClusterClient#cancelWithSavepoint(JobID jobId, @Nullable String 
> savepointDirectory)}}.
> by either taking a savepoint and cancel the job separately, or by migrating 
> the logic in {{JobCancellationWithSavepointHandlers}}. The former will have 
> different semantics because the checkpoint scheduler is not stopped. Thus it 
> is not guaranteed that there won't be additional checkpoints between the 
> savepoint and the job cancelation.

This message was sent by Atlassian JIRA

Reply via email to