[ 
https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374601#comment-16374601
 ] 

ASF GitHub Bot commented on FLINK-8746:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5560#discussion_r170296322
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java
 ---
    @@ -0,0 +1,42 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.checkpoint;
    +
    +import org.apache.flink.util.FlinkException;
    +import org.apache.flink.util.Preconditions;
    +
    +/**
    + * Exceptions which indicate that a checkpoint triggering has failed.
    + *
    + */
    +public class CheckpointTriggerException extends FlinkException {
    +
    +   private static final long serialVersionUID = -3330160816161901752L;
    +
    +   private final CheckpointDeclineReason checkpointDeclineReason;
    +
    +   public CheckpointTriggerException(String message, 
CheckpointDeclineReason checkpointDeclineReason) {
    +           super(message + " Decline reason: " + checkpointDeclineReason);
    --- End diff --
    
    Not super important because it is never logged but you could include the 
enums `.message()` into the exception message.


> Support rescaling of jobs which are not fully running
> -----------------------------------------------------
>
>                 Key: FLINK-8746
>                 URL: https://issues.apache.org/jira/browse/FLINK-8746
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> We should support the rescaling of jobs which are only partially running. 
> Currently, this fails because rescaling requires to take a savepoint. We can 
> solve the problem by falling back to the latest rescaling savepoint.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to