[
https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374600#comment-16374600
]
ASF GitHub Bot commented on FLINK-8746:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170300254
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -534,42 +536,94 @@ public void postStop() throws Exception {
// 4. take a savepoint
final CompletableFuture<String> savepointFuture =
triggerSavepoint(
- jobMasterConfiguration.getTmpDirectory(),
- timeout);
+ null,
+ timeout)
+ .handleAsync(
+ (String savepointPath, Throwable throwable) -> {
+ if (throwable != null) {
+ final Throwable
strippedThrowable = ExceptionUtils.stripCompletionException(throwable);
+ if (strippedThrowable
instanceof CheckpointTriggerException) {
+ final
CheckpointTriggerException checkpointTriggerException =
(CheckpointTriggerException) strippedThrowable;
+
+ if
(checkpointTriggerException.getCheckpointDeclineReason() ==
CheckpointDeclineReason.NOT_ALL_REQUIRED_TASKS_RUNNING) {
+ return
lastInternalSavepoint;
+ } else {
+ throw new
CompletionException(checkpointTriggerException);
+ }
+ } else {
+ throw new
CompletionException(strippedThrowable);
+ }
+ } else {
+ final String savepointToDispose
= lastInternalSavepoint;
--- End diff --
I think `savepointToDispose` be `null`.
> Support rescaling of jobs which are not fully running
> -----------------------------------------------------
>
> Key: FLINK-8746
> URL: https://issues.apache.org/jira/browse/FLINK-8746
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> We should support the rescaling of jobs which are only partially running.
> Currently, this fails because rescaling requires to take a savepoint. We can
> solve the problem by falling back to the latest rescaling savepoint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
