[ 
https://issues.apache.org/jira/browse/FLINK-8746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374692#comment-16374692
 ] 

ASF GitHub Bot commented on FLINK-8746:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5560#discussion_r170313695
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java 
---
    @@ -1156,6 +1213,26 @@ private void disposeSavepoint(String savepointPath) {
                }
        }
     
    +   /**
    +    * Tries to restore the given {@link ExecutionGraph} from the provided 
{@link SavepointRestoreSettings}.
    +    *
    +    * @param executionGraphToRestore {@link ExecutionGraph} which is 
supposed to be restored
    +    * @param savepointRestoreSettings {@link SavepointRestoreSettings} 
containing information about the savepoint to restore from
    +    * @throws Exception if the {@link ExecutionGraph} could not be restored
    +    */
    +   private void tryRestoreExecutionGraphFromSavepoint(ExecutionGraph 
executionGraphToRestore, SavepointRestoreSettings savepointRestoreSettings) 
throws Exception {
    +           if (savepointRestoreSettings.restoreSavepoint()) {
    +                   final CheckpointCoordinator checkpointCoordinator = 
executionGraphToRestore.getCheckpointCoordinator();
    +                   if (checkpointCoordinator != null) {
    --- End diff --
    
    The checks are not done at all call sites. Only in the constructor you have 
this check.


> Support rescaling of jobs which are not fully running
> -----------------------------------------------------
>
>                 Key: FLINK-8746
>                 URL: https://issues.apache.org/jira/browse/FLINK-8746
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> We should support the rescaling of jobs which are only partially running. 
> Currently, this fails because rescaling requires to take a savepoint. We can 
> solve the problem by falling back to the latest rescaling savepoint.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to