ASF GitHub Bot commented on FLINK-4569:

GitHub user zentol opened a pull request:


    [FLINK-4569][tests] Fix JobRetrievalITCase

    ## What is the purpose of the change
    This PR contains 2 changes to the `JobRetrievalITCase`.
    1) We now store exceptions that occur in the submitting thread in a 
`AtomicReference` that we evaluate at the end of the test.
    2) It could happen that the lock (preventing the job from terminating) was 
released before the client had a chance to finish the retrieval. To remedy this 
we now only release the lock if the thread has terminated, either by 
successfully connecting or failing with an error.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4569

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5681
commit d45d8883365ef73c7064adfd098feea208d2ca4c
Author: zentol <chesnay@...>
Date:   2018-03-12T11:01:57Z

    [FLINK-4569][tests] Fix JobRetrievalITCase


> JobRetrievalITCase.testJobRetrieval() does not forward exceptions to parent 
> thread.
> -----------------------------------------------------------------------------------
>                 Key: FLINK-4569
>                 URL: https://issues.apache.org/jira/browse/FLINK-4569
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>              Labels: test-stability
>             Fix For: 1.5.0
> The mentioned test seems to fail frequently, without being detected, because 
> the Assert.fail() is called in a separate thread which doesn't forward 
> exceptions.
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/156177995/log.txt

This message was sent by Atlassian JIRA

Reply via email to