[
https://issues.apache.org/jira/browse/FLINK-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396953#comment-16396953
]
ASF GitHub Bot commented on FLINK-4569:
---------------------------------------
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5689#discussion_r174135885
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/example/client/JobRetrievalITCase.java
---
@@ -119,6 +121,11 @@ public void run() {
lock.release();
resumingThread.join();
+
+ Throwable exception = error.get();
+ if (exception != null) {
+ throw new AssertionError(exception);
+ }
--- End diff --
Is this any different from using `Assert.assertNull(error.get())`? Not that
it makes any difference but just to know why you picked throwing the exception
here. Personally I think that the assertNull seems more explicit when you read
the code and it is less verbose.
> JobRetrievalITCase.testJobRetrieval() does not forward exceptions to parent
> thread.
> -----------------------------------------------------------------------------------
>
> Key: FLINK-4569
> URL: https://issues.apache.org/jira/browse/FLINK-4569
> Project: Flink
> Issue Type: Bug
> Components: Client
> Reporter: Robert Metzger
> Assignee: Chesnay Schepler
> Priority: Blocker
> Labels: test-stability
> Fix For: 1.5.0
>
>
> The mentioned test seems to fail frequently, without being detected, because
> the Assert.fail() is called in a separate thread which doesn't forward
> exceptions.
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/156177995/log.txt
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
