ASF GitHub Bot commented on FLINK-4569:

GitHub user zentol opened a pull request:


    [FLINK-4569][tests] Respect exceptions thrown in thread in 

    ## What is the purpose of the change
    This PR ensures that exceptions that occur in the submitting thread 
actually fail the test. Also contains minor fixes, like setting a thread name 
(for debugging purposes) and releasing the lock in the `SemaphoreInvokable` to 
allow multiple runs in the IDE.
    ## Verifying the change
    One can modify the test to throw an exception after connecting 
successfully, which will fail the test.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4569

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5689
commit 13c383d439550b1ebdc869981a7ffa19a6c8a151
Author: zentol <chesnay@...>
Date:   2018-03-13T12:00:47Z

    [FLINK-4569][tests] Respect exceptions thrown in thread in 


> JobRetrievalITCase.testJobRetrieval() does not forward exceptions to parent 
> thread.
> -----------------------------------------------------------------------------------
>                 Key: FLINK-4569
>                 URL: https://issues.apache.org/jira/browse/FLINK-4569
>             Project: Flink
>          Issue Type: Bug
>          Components: Client
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>            Priority: Blocker
>              Labels: test-stability
>             Fix For: 1.5.0
> The mentioned test seems to fail frequently, without being detected, because 
> the Assert.fail() is called in a separate thread which doesn't forward 
> exceptions.
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/156177995/log.txt

This message was sent by Atlassian JIRA

Reply via email to