Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5672#discussion_r175712900
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java
---
@@ -91,4 +91,9 @@ protected Configuration
applyCommandLineOptionsToConfiguration(CommandLine comma
return resultingConfiguration;
}
+
+ @Override
+ public boolean isDetachedMode(CommandLine commandLine) {
--- End diff --
I think the `CustomCommandLine` should not have this method. It is more of
a factory for a `ClusterDescriptor` and general options like this should go to
the `CLI` class.
---
