Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5672#discussion_r175714576
  
    --- Diff: 
flink-yarn/src/test/java/org/apache/flink/yarn/CliFrontendRunTestWithYarn.java 
---
    @@ -0,0 +1,155 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.yarn;
    +
    +import org.apache.flink.client.cli.CliFrontendTestUtils;
    +import org.apache.flink.client.deployment.ClusterSpecification;
    +import org.apache.flink.client.program.ClusterClient;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.CoreOptions;
    +import org.apache.flink.configuration.JobManagerOptions;
    +import org.apache.flink.runtime.jobgraph.JobGraph;
    +import org.apache.flink.util.FlinkException;
    +import org.apache.flink.yarn.cli.FlinkYarnSessionCli;
    +import org.apache.flink.yarn.util.FakeClusterClient;
    +import org.apache.flink.yarn.util.NonDeployingYarnClusterDescriptor;
    +
    +import org.apache.commons.cli.CommandLine;
    +import org.apache.hadoop.yarn.api.records.ApplicationId;
    +import org.apache.hadoop.yarn.client.api.YarnClient;
    +import org.apache.hadoop.yarn.conf.YarnConfiguration;
    +import org.junit.AfterClass;
    +import org.junit.BeforeClass;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.rules.TemporaryFolder;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +
    +import java.util.Arrays;
    +import java.util.List;
    +
    +import static junit.framework.TestCase.assertTrue;
    +import static 
org.apache.flink.client.cli.CliFrontendRunTest.verifyCliFrontend;
    +
    +/**
    + * Tests for the RUN command using a {@link 
org.apache.flink.yarn.cli.FlinkYarnSessionCli} inside
    + * the {@link org.apache.flink.client.cli.CliFrontend}.
    + *
    + * @see org.apache.flink.client.cli.CliFrontendRunTest
    + */
    +@RunWith(Parameterized.class)
    +public class CliFrontendRunTestWithYarn {
    --- End diff --
    
    `extends TestLogger` is missing


---

Reply via email to