Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5672#discussion_r175752444
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -225,7 +226,9 @@ protected void run(String[] args) throws Exception {
                        final ClusterClient<T> client;
     
                        // directly deploy the job if the cluster is started in 
job mode and detached
    -                   if (flip6 && clusterId == null && 
runOptions.getDetachedMode()) {
    +                   boolean detachedMode = 
customCommandLine.isDetachedMode(commandLine);
    +                   LOG.debug("Detached job mode is set to {}", 
detachedMode);
    +                   if (flip6 && clusterId == null && detachedMode) {
    --- End diff --
    
    I agree that we shouldn't have `-yd`, but it is part of the client API and 
unless we want to change existing behavior we can't rely on `RunOptions` alone.


---

Reply via email to