[ 
https://issues.apache.org/jira/browse/FLINK-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625216#comment-14625216
 ] 

ASF GitHub Bot commented on FLINK-2292:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/896#discussion_r34503354
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java
 ---
    @@ -101,9 +101,9 @@
     
        /**
         * For system internal usage only. Use getAccumulator(...) to obtain a
    -    * accumulator. Use this as read-only.
    +    * accumulator. The returned map must NOT be modified.
         */
    -   HashMap<String, Accumulator<?, ?>> getAllAccumulators();
    +   Map<String, Accumulator<?, ?>> getAllAccumulators();
    --- End diff --
    
    The comment says system-internal usage only, but I couldn't find any usages 
with IntelliJ. Should we remove this then? I guess that this has been replaced 
by the getSnapshot method of the registry.


> Report accumulators periodically while job is running
> -----------------------------------------------------
>
>                 Key: FLINK-2292
>                 URL: https://issues.apache.org/jira/browse/FLINK-2292
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, TaskManager
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 0.10
>
>
> Accumulators should be sent periodically, as part of the heartbeat that sends 
> metrics. This allows them to be updated in real time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to