[
https://issues.apache.org/jira/browse/FLINK-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625220#comment-14625220
]
ASF GitHub Bot commented on FLINK-2292:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/896#discussion_r34503586
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/functions/util/AbstractRuntimeUDFContext.java
---
@@ -53,32 +53,34 @@
private final ExecutionConfig executionConfig;
- private final HashMap<String, Accumulator<?, ?>> accumulators = new
HashMap<String, Accumulator<?, ?>>();
-
+ private final Map<String, Accumulator<?, ?>> accumulators;
+
private final DistributedCache distributedCache;
-
-
+
+
public AbstractRuntimeUDFContext(String name,
--- End diff --
I think a common practice is to have optional arguments last, e.g. the
cpTasks.
> Report accumulators periodically while job is running
> -----------------------------------------------------
>
> Key: FLINK-2292
> URL: https://issues.apache.org/jira/browse/FLINK-2292
> Project: Flink
> Issue Type: Sub-task
> Components: JobManager, TaskManager
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Fix For: 0.10
>
>
> Accumulators should be sent periodically, as part of the heartbeat that sends
> metrics. This allows them to be updated in real time.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
