[ 
https://issues.apache.org/jira/browse/FLINK-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14626054#comment-14626054
 ] 

ASF GitHub Bot commented on FLINK-2292:
---------------------------------------

Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/896#discussion_r34547975
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java 
---
    @@ -408,14 +408,16 @@ public long count() throws Exception {
                JobExecutionResult res = getExecutionEnvironment().execute();
     
                ArrayList<byte[]> accResult = res.getAccumulatorResult(id);
    -           try {
    -                   return 
SerializedListAccumulator.deserializeList(accResult, serializer);
    -           }
    -           catch (ClassNotFoundException e) {
    -                   throw new RuntimeException("Cannot find type class of 
collected data type.", e);
    -           }
    -           catch (IOException e) {
    -                   throw new RuntimeException("Serialization error while 
deserializing collected data", e);
    +           if (accResult != null) {
    +                   try {
    +                           return 
SerializedListAccumulator.deserializeList(accResult, serializer);
    +                   } catch (ClassNotFoundException e) {
    +                           throw new RuntimeException("Cannot find type 
class of collected data type.", e);
    +                   } catch (IOException e) {
    +                           throw new RuntimeException("Serialization error 
while deserializing collected data", e);
    +                   }
    +           } else {
    +                   throw new RuntimeException("The job result did not 
contain any accumulator data.");
    --- End diff --
    
    Then let's change it to
    > Collect returned no results.


> Report accumulators periodically while job is running
> -----------------------------------------------------
>
>                 Key: FLINK-2292
>                 URL: https://issues.apache.org/jira/browse/FLINK-2292
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, TaskManager
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>             Fix For: 0.10
>
>
> Accumulators should be sent periodically, as part of the heartbeat that sends 
> metrics. This allows them to be updated in real time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to