Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5775#discussion_r177543886
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -659,7 +660,7 @@ public void disconnectResourceManager() {
.orTimeout(pendingRequest.getAllocatedSlotFuture(),
allocationTimeout.toMilliseconds(), TimeUnit.MILLISECONDS)
.whenCompleteAsync(
(AllocatedSlot ignored, Throwable throwable) ->
{
- if (throwable != null) {
+ if (throwable instanceof
TimeoutException) {
--- End diff --
Are we not losing some information by swallowing other types of exceptions?
---
