Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5775#discussion_r177544954
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -465,6 +464,58 @@ public void
testSchedulingOperationCancellationWhenCancel() throws Exception {
assertThat(executionGraph.getTerminationFuture().get(),
is(JobStatus.CANCELED));
}
+ @Nonnull
+ private TestingLogicalSlot createTestingSlot(@Nullable
CompletableFuture<?> releaseFuture) {
--- End diff --
nit: make static and move below:
```
//
------------------------------------------------------------------------
// Utilities
//
------------------------------------------------------------------------
```
---
