[GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5775#discussion_r177544459
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
 ---
    @@ -465,6 +464,58 @@ public void 
testSchedulingOperationCancellationWhenCancel() throws Exception {
                assertThat(executionGraph.getTerminationFuture().get(), 
is(JobStatus.CANCELED));
        }
     
    +   @Nonnull
    +   private TestingLogicalSlot createTestingSlot(@Nullable 
CompletableFuture<?> releaseFuture) {
    +           return new TestingLogicalSlot(
    +                   new LocalTaskManagerLocation(),
    +                   new SimpleAckingTaskManagerGateway(),
    +                   0,
    +                   new AllocationID(),
    +                   new SlotRequestId(),
    +                   new SlotSharingGroupId(),
    +                   releaseFuture);
    +   }
    +
    +   /**
    +    * Tests that a partially completed eager scheduling operation fails if 
an
    --- End diff --
    
    nit: *[...] if an completed [...]*


---