[ https://issues.apache.org/jira/browse/FLINK-9059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425558#comment-16425558 ]
ASF GitHub Bot commented on FLINK-9059: --------------------------------------- Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5758#discussion_r179149794 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -29,38 +30,47 @@ /** * Environment configuration that represents the content of an environment file. Environment files - * define sources, execution, and deployment behavior. An environment might be defined by default or + * define tables, execution, and deployment behavior. An environment might be defined by default or * as part of a session. Environments can be merged or enriched with properties (e.g. from CLI command). * * <p>In future versions, we might restrict the merging or enrichment of deployment properties to not * allow overwriting of a deployment by a session. */ public class Environment { - private Map<String, Source> sources; + private Map<String, TableDescriptor> tables; --- End diff -- Why not maintaining two separate maps for sources and sinks? Then we don't need instance of checks. If a table is both we can simply add it to both maps. > Add support for unified table source and sink declaration in environment file > ----------------------------------------------------------------------------- > > Key: FLINK-9059 > URL: https://issues.apache.org/jira/browse/FLINK-9059 > Project: Flink > Issue Type: Task > Components: Table API & SQL > Reporter: Shuyi Chen > Assignee: Shuyi Chen > Priority: Major > Fix For: 1.5.0 > > > 1) Add a common property called "type" with single value 'source'. > 2) in yaml file, replace "sources" with "tables". -- This message was sent by Atlassian JIRA (v7.6.3#76005)