Github user suez1224 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5758#discussion_r178330131
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableDescriptor.scala
---
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.descriptors
+
+import org.apache.flink.table.descriptors.DescriptorProperties.toScala
+import
org.apache.flink.table.descriptors.StatisticsValidator.{STATISTICS_COLUMNS,
STATISTICS_ROW_COUNT, readColumnStats}
+import org.apache.flink.table.plan.stats.TableStats
+
+import scala.collection.JavaConverters._
+
+/**
+ * Common class for all descriptors describing table sources and sinks.
+ */
+abstract class TableDescriptor extends Descriptor {
+
+ protected var connectorDescriptor: Option[ConnectorDescriptor] = None
+ protected var formatDescriptor: Option[FormatDescriptor] = None
+ protected var schemaDescriptor: Option[Schema] = None
+ protected var statisticsDescriptor: Option[Statistics] = None
+ protected var metaDescriptor: Option[Metadata] = None
+
+ /**
+ * Internal method for properties conversion.
+ */
+ override private[flink] def addProperties(properties:
DescriptorProperties): Unit = {
+ connectorDescriptor.foreach(_.addProperties(properties))
+ formatDescriptor.foreach(_.addProperties(properties))
+ schemaDescriptor.foreach(_.addProperties(properties))
+ metaDescriptor.foreach(_.addProperties(properties))
+ }
+
+ /**
+ * Reads table statistics from the descriptors properties.
+ */
+ protected def getTableStats: Option[TableStats] = {
+ val normalizedProps = new DescriptorProperties()
+ addProperties(normalizedProps)
+ val rowCount =
toScala(normalizedProps.getOptionalLong(STATISTICS_ROW_COUNT))
+ rowCount match {
+ case Some(cnt) =>
+ val columnStats = readColumnStats(normalizedProps,
STATISTICS_COLUMNS)
+ Some(TableStats(cnt, columnStats.asJava))
+ case None =>
+ None
+ }
+ }
+}
+
+object TableDescriptor {
+ /**
+ * Key for describing the type of this table, valid values are
('source').
+ */
+ val TABLE_TYPE = "type"
+
+ /**
+ * Valid TABLE_TYPE value.
+ */
+ val TABLE_TYPE_SOURCE = "source"
--- End diff --
The convention in the code currently uses just constants, please see
KafkaValidator or RowtimeValidator. Also, it seems to be premature optimization
to me given such simple use of the constant.
---
