Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5758#discussion_r179149794
  
    --- Diff: 
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java
 ---
    @@ -29,38 +30,47 @@
     
     /**
      * Environment configuration that represents the content of an environment 
file. Environment files
    - * define sources, execution, and deployment behavior. An environment 
might be defined by default or
    + * define tables, execution, and deployment behavior. An environment might 
be defined by default or
      * as part of a session. Environments can be merged or enriched with 
properties (e.g. from CLI command).
      *
      * <p>In future versions, we might restrict the merging or enrichment of 
deployment properties to not
      * allow overwriting of a deployment by a session.
      */
     public class Environment {
     
    -   private Map<String, Source> sources;
    +   private Map<String, TableDescriptor> tables;
    --- End diff --
    
    Why not maintaining two separate maps for sources and sinks? Then we don't 
need instance of checks. If a table is both we can simply add it to both maps.


---

Reply via email to