[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425114#comment-16425114
]
ASF GitHub Bot commented on FLINK-8835:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179045805
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -299,15 +299,15 @@
/**
* Flag indicating whether to start a thread, which repeatedly logs the
memory usage of the JVM.
*
- * @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_START_LOG_THREAD} instead
+ * @deprecated use {@link TaskManagerOptions#DEBUG_MEMORY_LOG} instead
*/
@Deprecated
- public static final String
TASK_MANAGER_DEBUG_MEMORY_USAGE_START_LOG_THREAD =
"taskmanager.debug.memory.startLogThread";
+ public static final String TASK_MANAGER_DEBUG_MEMORY_LOG =
"taskmanager.debug.memory.log";
/**
* The interval (in ms) for the log thread to log the current memory
usage.
*
- * @deprecated use {@link
TaskManagerOptions#DEBUG_MEMORY_USAGE_LOG_INTERVAL_MS} instead
--- End diff --
I would revert the renaming; it' a useful piece of info that we're dealing
with milliseconds.
> Fix TaskManager config keys
> ---------------------------
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Reporter: Stephan Ewen
> Assignee: mingleizhang
> Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
