[ 
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425182#comment-16425182
 ] 

ASF GitHub Bot commented on FLINK-8835:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5808#discussion_r179061417
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java 
---
    @@ -104,40 +104,40 @@
                                " global ssl flag " + 
SecurityOptions.SSL_ENABLED.key() + " is set to true");
     
        /**
    -    * The initial registration pause between two consecutive registration 
attempts. The pause
    -    * is doubled for each new registration attempt until it reaches the 
maximum registration pause.
    +    * The initial registration backoff between two consecutive 
registration attempts. The backoff
    +    * is doubled for each new registration attempt until it reaches the 
maximum registration backoff.
         */
    -   public static final ConfigOption<String> INITIAL_REGISTRATION_PAUSE =
    -           key("taskmanager.initial-registration-pause")
    +   public static final ConfigOption<String> INITIAL_REGISTRATION_BACKOFF =
    +           key("taskmanager.registration.initial-backoff")
    --- End diff --
    
    ```
        public static final ConfigOption<String> INITIAL_REGISTRATION_BACKOFF =
                key("taskmanager.registration.initial-backoff")
                        .defaultValue("500 ms")
    ====>               
.withDeprecatedKeys("taskmanager.initial-registration-pause") 
                        .withDescription("....");
    ```


> Fix TaskManager config keys
> ---------------------------
>
>                 Key: FLINK-8835
>                 URL: https://issues.apache.org/jira/browse/FLINK-8835
>             Project: Flink
>          Issue Type: Bug
>          Components: TaskManager
>            Reporter: Stephan Ewen
>            Assignee: mingleizhang
>            Priority: Blocker
>              Labels: easy-fix
>             Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming 
> scheme. We need to clear those up before the release. I would also suggest to 
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also 
> make some of the existing keys more hierarchical harmonize them with the 
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to 
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} => 
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} => 
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} => 
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} => 
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}} 
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> * 
> {{taskmanager.registration.timeout}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to