[
https://issues.apache.org/jira/browse/FLINK-8835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425162#comment-16425162
]
ASF GitHub Bot commented on FLINK-8835:
---------------------------------------
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5808#discussion_r179060468
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
---
@@ -104,40 +104,40 @@
" global ssl flag " +
SecurityOptions.SSL_ENABLED.key() + " is set to true");
/**
- * The initial registration pause between two consecutive registration
attempts. The pause
- * is doubled for each new registration attempt until it reaches the
maximum registration pause.
+ * The initial registration backoff between two consecutive
registration attempts. The backoff
+ * is doubled for each new registration attempt until it reaches the
maximum registration backoff.
*/
- public static final ConfigOption<String> INITIAL_REGISTRATION_PAUSE =
- key("taskmanager.initial-registration-pause")
+ public static final ConfigOption<String> INITIAL_REGISTRATION_BACKOFF =
+ key("taskmanager.registration.initial-backoff")
--- End diff --
I think there already has deprecated key
```"taskmanager.initial-registration-pause"``` in the
```ConfigConstants.java``` file. Below:
```
/**
* The initial registration pause between two consecutive registration
attempts. The pause
* is doubled for each new registration attempt until it reaches the
maximum registration pause.
*
* @deprecated use {@link TaskManagerOptions#INITIAL_REGISTRATION_BACKOFF}
instead
*/
@Deprecated
public static final String TASK_MANAGER_INITIAL_REGISTRATION_PAUSE =
"taskmanager.initial-registration-pause";
```
Or, I am guessing what you mean is that I should change the value
```taskmanager.initial-registration-pause``` to
```taskmanager.registration.initial-backoff``` in ```ConfigConstants.java```
file. But you said ((nor should we change the value)) before. So, Hmm. Am I
missing something ?
> Fix TaskManager config keys
> ---------------------------
>
> Key: FLINK-8835
> URL: https://issues.apache.org/jira/browse/FLINK-8835
> Project: Flink
> Issue Type: Bug
> Components: TaskManager
> Reporter: Stephan Ewen
> Assignee: mingleizhang
> Priority: Blocker
> Labels: easy-fix
> Fix For: 1.5.0
>
>
> Many new config keys in the TaskManager don't follow the proper naming
> scheme. We need to clear those up before the release. I would also suggest to
> keep the key names short, because that makes it easier for users.
> When doing this cleanup pass over the config keys, I would suggest to also
> make some of the existing keys more hierarchical harmonize them with the
> common scheme in Flink.
> h1. New Keys
> * {{taskmanager.network.credit-based-flow-control.enabled}} to
> {{taskmanager.network.credit-model}}.
> h1. Existing Keys
> * {{taskmanager.debug.memory.startLogThread}} =>
> {{taskmanager.debug.memory.log}}
> * {{taskmanager.debug.memory.logIntervalMs}} =>
> {{taskmanager.debug.memory.log-interval}}
> * {{taskmanager.initial-registration-pause}} =>
> {{taskmanager.registration.initial-backoff}}
> * {{taskmanager.max-registration-pause}} =>
> {{taskmanager.registration.max-backoff}}
> * {{taskmanager.refused-registration-pause}}
> {{taskmanager.registration.refused-backoff}}
> * {{taskmanager.maxRegistrationDuration}} ==> *
> {{taskmanager.registration.timeout}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
