Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/5860#discussion_r183754480
--- Diff:
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
---
@@ -472,6 +480,15 @@ private boolean shouldRoll(BucketState<T> bucketState)
throws IOException {
subtaskIndex,
writePosition,
batchSize);
+ } else {
--- End diff --
update method comment.---
