Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5860#discussion_r183754129
  
    --- Diff: 
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
 ---
    @@ -87,9 +87,11 @@
      * and a rolling counter. For example the file {@code "part-1-17"} 
contains the data from
      * {@code subtask 1} of the sink and is the {@code 17th} bucket created by 
that subtask. Per default
      * the part prefix is {@code "part"} but this can be configured using 
{@link #setPartPrefix(String)}.
    - * When a part file becomes bigger than the user-specified batch size the 
current part file is closed,
    - * the part counter is increased and a new part file is created. The batch 
size defaults to {@code 384MB},
    - * this can be configured using {@link #setBatchSize(long)}.
    + * When a part file becomes bigger than the user-specified batch size or 
when the part file becomes older
    + * than the user-specified roll over interval the current part file is 
closed,the part counter is increased
    + * and a new part file is created. The batch size defaults to {@code 
384MB},this can be configured
    --- End diff --
    
    Add space `{@code 384MB},this` -> `{@code 384MB}, this`


---

Reply via email to