[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

[glaksh100]

Github user glaksh100 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5860#discussion_r186223237
  
    --- Diff: 
flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java
 ---
    @@ -473,6 +482,15 @@ private boolean shouldRoll(BucketState<T> bucketState) 
throws IOException {
                                        subtaskIndex,
                                        writePosition,
                                        batchSize);
    +                   } else {
    +                           long currentProcessingTime = 
processingTimeService.getCurrentProcessingTime();
    --- End diff --
    
    Updated method signature for `shouldRoll` to include the 
`currentProcessingTime` 


---