Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5950#discussion_r185825767
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSerializationUtil.java
 ---
    @@ -200,7 +197,7 @@ public static void 
writeSerializersAndConfigsWithResilience(
                        for (int i = 0; i < numSerializersAndConfigSnapshots; 
i++) {
     
                                bufferWithPos.setPosition(offsets[i * 2]);
    -                           serializer = tryReadSerializer(bufferWrapper, 
userCodeClassLoader);
    +                           serializer = tryReadSerializer(bufferWrapper, 
userCodeClassLoader, true);
    --- End diff --
    
    This could be the place where we catch a `UnloadableSerializerException`, 
but if we let the caller do the iteration from 0 to 
`numSerializersAndConfigSnapshots`, we can push it out even more. Why is it 
helpful to create a list here? Otherwise we can do the exception handling in 
the caller and more fine grained.


---

Reply via email to